build: Use ldflags in win-{gvproxy,sshproxy} targets

[cfergeau]

The windowsgui binary is currently 50% bigger than its non-windowsgui
counterpart. This size difference is gone when win-gvproxy is built with
'-s -w' as the other binaries.

[cfergeau]

@n1hility can you take a look?

[n1hility]

@cfergeau I can see stripping DWARF, but with trying to get more analysis out of crashes/hangs, I wonder if we should not strip symbols? crash dumps and debug backtraces (native stacks) are near impossible to gather without these.

[cfergeau]

@cfergeau I can see stripping DWARF, but with trying to get more analysis out of crashes/hangs, I wonder if we should not strip symbols? crash dumps and debug backtraces (native stacks) are near impossible to gather without these.

I could have described this PR as "use same build/linker flags for all binaries", which would make the discussion about stripping the binaries slightly orthogonal to the PR :)

To be honest, so far, with go programs, I did not have many (any?) bugs where the only information to fix it was a backtrace, so between debug symbols and a 30% to 50% increase in binary size, the choice is easily made. But maybe you had a different experience with that?
What we could do is strip binaries by default, but add a 'debug' tarball to the release artifacts, so that people can switch to the debug binaries if needed? This would be a similar approach to that of linux distros which ship debug infos in separate packages?

[praveenkumar]

@cfergeau I can see stripping DWARF, but with trying to get more analysis out of crashes/hangs, I wonder if we should not strip symbols? crash dumps and debug backtraces (native stacks) are near impossible to gather without these.

What we could do is strip binaries by default, but add a 'debug' tarball to the release artifacts, so that people can switch to the debug binaries if needed? This would be a similar approach to that of linux distros which ship debug infos in separate packages?

I think that is better approach if we really want to ship debug info as part of binary. By default better to have same linker flag for each target.

[praveenkumar]

👍🏼

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cfergeau]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment