Improve gvproxy error reporting, and improve gvproxy --version in a corner case #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some errors are currently not logged, or without much context. This commit adds prefixes to some of these, to make it easier to understand the codepaths which caused gvproxy to exit. Signed-off-by: Christophe Fergeau <[email protected]>
if an annotated tag is found, the git describe string will be similar to: v0.7.2-15-g2c897d90 When using shallow clones, the commit being built may not have an annotated tag in its history, `git describe` will only be the abbreviated commit hash in this case: 2c897d9 This commit tries to detect these situations, and adds a 'git' prefix to the hash in these cases to make the version info look a bit better: $ gvproxy --version: gvproxy version git2c897d90 Signed-off-by: Christophe Fergeau <[email protected]>
gvproxy --version uses the `git describe` to automatically generate the version. actions/checkout by default creates a 1 commit checkout with no history/no tags, which will prevent git describe from generating a useful version. This commit instructs actions/checkout to use full checkouts with all tags. Signed-off-by: Christophe Fergeau <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the git commit logs for more details about what was done.