ghactions: Don't upload artifacts multiple times #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
force-pushed
the
ghactions-if
branch
from
5ec4f61 to
0829c78
Compare
With the addition of a matrix of go versions to test the build with, the artifact upload will also be run multiple time. If they run concurrently, this will cause unexpected upload failures. Only publish the '1.21.x' artifact. Signed-off-by: Christophe Fergeau <[email protected]>
cfergeau
force-pushed
the
ghactions-if
branch
from
0829c78 to
2d8f37b
Compare
|
LGTM |
This may help with the failures we are seeing in github actions. Signed-off-by: Christophe Fergeau <[email protected]>
|
/lgtm |
praveenkumar
approved these changes
Jan 29, 2024
| @@ -29,6 +29,7 @@ jobs: | |||
| mv bin/gvproxy.exe bin/gvproxy-windowsgui.exe | |||
|
|
|||
| - uses: actions/upload-artifact@v3 | |||
| if: ${{ matrix.go-version }} == '1.21.x' | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of a matrix of go versions to test the build with, the
artifact upload will also be run multiple time. If they run
concurrently, this will cause unexpected upload failures.
Only publish the '1.21.x' artifact.