-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: github.com/u-root/uio vd2acac8f3701 #356
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: loong-hy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For what it's worth, I'd have a preference for not updating to latest u-root/uio which requires golang 1.21, but to update to a slightly older version which still builds with loong64. I've tried this in cfergeau@62e19dd If you think we should go with your version, can you add a |
This uses an updated github.com/u-root/uio which fixes building with GOARCH=loong64 This build issue was reported by Huang Yang <[email protected]> in containers#356 Signed-off-by: Christophe Fergeau <[email protected]>
Using an older u-root/uio version would allow us to keep golang 1.20 compatibility. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I've opened #366 to try and solve this issue. |
I approved the PR of @cfergeau, but am unable to verify this. The only Loongson (龙芯) I have is the much older Loongson 3A ;-). So I only based this on the dependencies and upgrade for our current primary archs. |
Closing as #366 has been merged. |
This is fix build error in loong64