Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: github.com/u-root/uio vd2acac8f3701 #356

Closed
wants to merge 1 commit into from

Conversation

loong-hy
Copy link

This is fix build error in loong64

Copy link
Contributor

openshift-ci bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: loong-hy
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau
Copy link
Collaborator

For what it's worth, I'd have a preference for not updating to latest u-root/uio which requires golang 1.21, but to update to a slightly older version which still builds with loong64. I've tried this in cfergeau@62e19dd

If you think we should go with your version, can you add a Signed-off-by tag as described here https://github.com/containers/gvisor-tap-vsock/pull/356/checks?check_run_id=24844594438 ?

cfergeau added a commit to cfergeau/gvisor-tap-vsock that referenced this pull request May 15, 2024
This uses an updated github.com/u-root/uio which fixes building with
GOARCH=loong64

This build issue was reported by Huang Yang <[email protected]> in
containers#356

Signed-off-by: Christophe Fergeau <[email protected]>
@cfergeau
Copy link
Collaborator

For what it's worth, I'd have a preference for not updating to latest u-root/uio which requires golang 1.21, but to update to a slightly older version which still builds with loong64. I've tried this in cfergeau@62e19dd

Using an older u-root/uio version would allow us to keep golang 1.20 compatibility.
However, #350 will also introduce a go 1.21 requirement, so this is less of a problem.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cfergeau
Copy link
Collaborator

I've opened #366 to try and solve this issue.

@gbraad
Copy link
Member

gbraad commented Jul 23, 2024

I approved the PR of @cfergeau, but am unable to verify this. The only Loongson (龙芯) I have is the much older Loongson 3A ;-). So I only based this on the dependencies and upgrade for our current primary archs.

@cfergeau
Copy link
Collaborator

Closing as #366 has been merged.

@cfergeau cfergeau closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants