test: Use ubuntu runner instead of macos runner for tests #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use 1.22.x instead Signed-off-by: Christophe Fergeau <[email protected]>
The current implementation hardcodes that the binary name is qemu-system-x86_64 on macOS, and qemu-kvm otherwise. Otherwise, on an ubuntu runner, the binary name will be qemu-system-x86_64. This commit makes use of exec.LookPath() to detect the correct binary name. Signed-off-by: Christophe Fergeau <[email protected]>
This is needed when running `qemu-system-x86_64` instead of `qemu-kvm` Signed-off-by: Christophe Fergeau <[email protected]>
cfergeau
force-pushed
the
ghactions
branch
3 times, most recently
from
8c128be to
b87e647
Compare
This commit changes uses of actions/setup-go to pick the go version required in go.mod. This means we'll be using the same go version everywhere, and since there is no major version hardcoded (such as '1.20.x'), this means we don't need to remember to update it once in a while. Signed-off-by: Christophe Fergeau <[email protected]>
M1 macos runners can't build our test code, and the M1 runners don't support nested virt, which is required by `make test` Since I expect in the future the x86_64 macos runners to go away, and since the ubuntu runners now support nested virt, this commit uses an ubuntu runner to run `make test`. This fixes containers#358 Signed-off-by: Christophe Fergeau <[email protected]>
|
I think the packer failures on centos stream 8 and fedora eln are unrelated to this PR. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3f7ef77
into
containers:main
18 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M1 macos runners can't build our test code, and the M1 runners don't
support nested virt, which is required by
make testSince I expect in thefuture the x86_64 macos runners to go away, and since the ubuntu runners
now support nested virt, this commit uses an ubuntu runner to run
make test.