Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit: remove EL8 and enable C10S downstream update #360

Merged
merged 1 commit into from
May 17, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 17, 2024

CentOS Stream 8 will be going EOL end of May and nothing new from upstream will be shipped there. We have also removed all EL8 targets from the podman-next copr. So, this commit removes all EL8 targets from the packit config.

RPM spec file syncing to CentOS Stream 10 dist-git has also been enabled in this commit. NOTE: Packit support for CentOS Stream is not yet on the same level as for Fedora. The CentOS Stream maintainer would still need to manually run packit propose-downstream -p gvisor-tap-vsock-centos and centpkg build after the dist-git PR has merged. Unfortunately, packit will also file an upstream issue because the CentOS Stream 10 rpm update job failed. Such issues can simply be closed for the time being.

This commit also removes the explicit targets specification for podman-next COPR so that all the targets enabled on that copr can be used automatically. This does work on all other projects that submit builds to podman-next. We can revisit this if things don't work as expected.

CentOS Stream 8 will be going EOL end of May and nothing new from
upstream will be shipped there. We have also removed all EL8 targets
from the podman-next copr. So, this commit removes all EL8 targets from
the packit config.

RPM spec file syncing to CentOS Stream 10 dist-git has also been enabled
in this commit. NOTE: Packit support for CentOS Stream is not yet on the
same level as for Fedora. The CentOS Stream maintainer would still need to
manually run `packit propose-downstream -p gvisor-tap-vsock-centos` and
`centpkg build` after the dist-git PR has merged. Unfortunately, packit
will also file an upstream issue because the CentOS Stream 10 rpm update job
failed. Such issues can simply be closed for the time being.

This commit also removes the explicit targets specification for
podman-next COPR so that all the targets enabled on that copr can be
used automatically. This does work on all other projects that submit
builds to podman-next. We can revisit this if things don't work as
expected.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented May 17, 2024

ELN environment fixes don't seem to have landed yet. We can ignore ELN failures.

@lsm5 lsm5 marked this pull request as ready for review May 17, 2024 13:53
@lsm5
Copy link
Member Author

lsm5 commented May 17, 2024

@cfergeau PTAL. this should be good to go.

@cfergeau
Copy link
Collaborator

/lgtm
/approve
The go/tests failure is a known issue, and the fedora-eln build failures are also being fixed.

Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 462b2bd into containers:main May 17, 2024
19 of 22 checks passed
@lsm5 lsm5 deleted the packit-env-updates branch May 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants