Fix OS specific url handling for unix:// scheme in transport

[arixmkii]

Fixes #371

Replaces #372

Details why it changed in #371 (comment)

This adds handling for unix:// scheme under Windows with absolute path (containing drive letter). This replicates the one from ssh_forwarder (

gvisor-tap-vsock/pkg/sshclient/ssh_forwarder.go

Line 114 in 6dbbe08

path := socketURI.Path

).

Test command:

gvproxy.exe -debug -mtu 1500 -ssh-port 50402 -listen-qemu unix:///C:/Users/Arthu/AppData/Local/Temp/podman/podman-machine-default-gvproxy.sock -forward-sock unix:///C:/Users/Arthu/AppData/Local/Temp/podman/podman-machine-default-api.sock -forward-dest /run/user/1000/podman/podman.sock -forward-user core -forward-identity C:\\Users\\Arthu\\.local\\share\\containers\\podman\\machine\\machine -pid-file C:\\Users\\Arthu\\AppData\\Local\\Temp\\podman\\gvproxy.pid

[arixmkii]

@cfergeau could you review this fix? It makes behavior consistent between different sockets (ssh forwarder and vlan transport) of the same scheme unix://

[arixmkii]

I will check win-sshproxy-tests.

All passed locally

go test -v .\test-win-sshproxy
=== RUN   TestSuite
Running Suite: win-sshproxy suite
=================================
Random Seed: 1721728332
Will run 3 of 3 specs

+++
Ran 3 of 3 Specs in 0.856 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestSuite (0.86s)
PASS
ok      github.com/containers/gvisor-tap-vsock/test-win-sshproxy        1.122s

[cfergeau]

I will check win-sshproxy-tests.

It's flakey/racy, sometimes it needs to be run a few times in ghactions until it passes :-/

[cfergeau]

I will check win-sshproxy-tests.

It's flakey/racy, sometimes it needs to be run a few times in ghactions until it passes :-/

And the wikipedia failure in Go/tests will be fixed as part of #370

[cfergeau]

@cfergeau could you review this fix? It makes behavior consistent between different sockets (ssh forwarder and vlan transport) of the same scheme unix://

Hopefully there are no Windows users who rely on unix:///Absolute/Path/No/Drive on Windows. Can you add to the commit log what you put in the PR description? ( #373 (comment) )

[cfergeau]

Apart from this,
/lgtm

[arixmkii]

Forced pushed with updated commit message.

Hopefully there are no Windows users who rely on unix:///Absolute/Path/No/Drive on Windows.

AFAIK there are no users (it used to work with QEMU machine setup, but was never a supported option advertised). I plan to submit issue and PR for exposing Podman API via unix:// socket on Windows for Hyper-V machine (so, one could potentially use automation via shell script + curl tool), but this is only on a concept level right now.

[cfergeau]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arixmkii, cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cfergeau]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment