-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packit: Don't attempt to build on f39 #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once Fedora 41 is released, fedora-latest-stable
will point to fedora-41
and -development
will point only to rawhide
. So, you might wanna include an explicit fedora-40
to account for F41 release.
It only has go 1.21 while we switched to go 1.22, so gvisor-tap-vsock fails to build on f39. I don't expect significant changes to gvisor-tap-vsock during the remaining f39 lifetime, at worse podman in f39 can keep using an older gvproxy release. Signed-off-by: Christophe Fergeau <[email protected]>
I added f40, but we can revert this commit once f41 is released. |
But even f41 release, f-39 will be EOL but not f-40 so may be we should keep using it until we again update go version which is not built for f-40 :) |
Since commit 8de6b91, builds with go 1.21 are no longer supported. This commit updates the go versions used in GitHub Actions to 1.22 and 1.23. Signed-off-by: Christophe Fergeau <[email protected]>
If we revert, we get back to |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8794a1f
into
containers:main
It only has go 1.21 while we switched to go 1.22, so gvisor-tap-vsock
fails to build on f39.
I don't expect significant changes to gvisor-tap-vsock during the
remaining f39 lifetime, at worse podman in f39 can keep using an older
gvproxy release.