Check 'hosts' file records, during handling DNS requests #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
force-pushed
the
hosts-file-records
branch
from
0d206fc to
7f9dc16
Compare
cfergeau
reviewed
Sep 24, 2024
pkg/services/dns/hosts_file.go
Outdated
|
|
||
| func (h *hosts) updateHostsFile() error { | ||
| h.hostsReadLock.RLock() | ||
| defer h.hostsReadLock.RUnlock() |
There was a problem hiding this comment.
This method is updating data structures (h) shared between multiple go routines, this should be taking a write lock (WLock())
You don't need to do it before the readHostsFile call though, as it's not changing any shared state, this could be moved just before h.hostsFile = newHosts
This implementation use 'libhosty' lib to read and search for hosts file records. It reads 'hosts' file first and adds file watcher to track changes in 'hosts' file Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob
force-pushed
the
hosts-file-records
branch
from
7f9dc16 to
3ea66d1
Compare
cfergeau
reviewed
Oct 1, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, evidolob The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit de690ca
into
containers:main
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation use 'libhosty' lib to read and search for hosts file records. It reads 'hosts' file first and adds file watcher to track changes in 'hosts' file