Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash with empty resolv.conf #420

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

siretart
Copy link

@siretart siretart commented Nov 8, 2024

Fixes: #417
Signed-off-by: Reinhard Tartler [email protected]

@cfergeau
Copy link
Collaborator

There is also this lint failure to fix:

cd tools && GOBIN="/home/runner/work/gvisor-tap-vsock/gvisor-tap-vsock/tools/bin" go install github.com/golangci/golangci-lint/cmd/golangci-lint
"/home/runner/work/gvisor-tap-vsock/gvisor-tap-vsock/tools/bin"/golangci-lint run
pkg/services/dns/dns_config_unix.go:6: File is not `goimports`-ed (goimports)
	"errors"
make: *** [Makefile:49: lint] Error 1

@cfergeau
Copy link
Collaborator

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, siretart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7e0fa97 into containers:main Nov 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panics on systems with empty /etc/resolv.conf
3 participants