Skip to content

Commit

Permalink
build: verify buildability of binaries in CI.
Browse files Browse the repository at this point in the history
Add missing verification of binary builds. Run verifications
in CI one at a time for more granular error reports. Update
the collective verify build target to run all verifications
in a single go.

Signed-off-by: Krisztian Litkey <[email protected]>
  • Loading branch information
klihub authored and askervin committed Sep 20, 2024
1 parent 189c8c3 commit 542fe43
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 9 deletions.
26 changes: 18 additions & 8 deletions .github/workflows/project-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,28 +20,38 @@ jobs:
runs-on: ubuntu-22.04
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
- name: Check out repository
uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-go@v5

- name: Install golang toolchain
uses: actions/setup-go@v5
with:
go-version: ${{ env.GO_VERSION }}

- name: make verify
- name: Verify dependencies
run: |
make verify-godeps
- name: Verify formatting
run: |
make verify-fmt
- name: Verify generated assets
run: |
make verify
make verify-generate
- name: Build docs
- name: Verify binary builds
run: |
make site-build
make clean-html
make verify-build
- name: Install gh-pages build dependencies
run: |
pip3 install --user -r docs/requirements.txt
echo "`python3 -m site --user-base`/bin" >> $GITHUB_PATH
- name: Verify update of gh-pages
- name: Verify documentation / update of gh-pages
run: |
git config user.name "Github"
git config user.email "[email protected]"
Expand Down
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ allclean: clean clean-cache

test: test-gopkgs

verify: verify-godeps verify-fmt verify-generate
verify: verify-godeps verify-fmt verify-generate verify-build verify-docs

#
# build targets
Expand Down Expand Up @@ -397,6 +397,10 @@ verify-generate: generate
exit "$$ec"; \
fi

verify-build: build

verify-docs: site-build clean-html

#
# targets for installing dependencies
#
Expand Down

0 comments on commit 542fe43

Please sign in to comment.