Fix image SCP when not providing quiet

Due to a logic error when trying to use the image scp functionality the destination wasn't passed unless "quiet" was also set. Signed-off-by: Hein-Pieter van Braam <[email protected]>
containers · Sep 3, 2023 · 14f5b46 · 14f5b46
1 parent c8abef1
commit 14f5b46
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/podman/domain/images_manager.py b/podman/domain/images_manager.py
@@ -411,11 +411,10 @@ def scp(
         Raises:
             APIError: when service returns an error
         """
-        params = {}
-        if dest is not None and quiet:
-            params = {"destination": dest, "quiet": quiet}
-        elif quiet:
-            params = {"quiet": quiet}
+        params = {"quiet": quiet}
+        if dest is not None:
+            params["destination"] = dest
+
         response = self.client.post(f"/images/scp/{source}", params=params)
         response.raise_for_status()
         return response.json()