Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workdir as alias for working_dir #368

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

umohnani8
Copy link
Member

Currently podman-py uses all three versions of work_dir, working_dir and workdir (not to mention WorkingDir).

This commit tries to unify the parameter usage by allowing workdir for container create or run. For backwards compatibility working_dir still works.

Since upstream Podman uses a variety of workdir versions the podman-py codebase can't be simplified further.

Fix: #330

Currently `podman-py` uses all three versions of `work_dir`,
`working_dir` and `workdir` (not to mention `WorkingDir`).

This commit tries to unify the parameter usage by allowing `workdir` for
container `create` or `run`. For backwards compatibility `working_dir`
still works.

Since upstream Podman uses a variety of *workdir* versions the
`podman-py` codebase can't be simplified further.

Fix: containers#330

Signed-off-by: Paul Spooren <[email protected]>
Signed-off-by: Urvashi Mohnani <[email protected]>
@umohnani8
Copy link
Member Author

Replacing #332

@rhatdan
Copy link
Member

rhatdan commented Jan 22, 2024

What about the tests?

@umohnani8
Copy link
Member Author

@rhatdan no tests are needed, we are just adding an alias

@umohnani8
Copy link
Member Author

@lsm5 @jwhonce @rhatdan PTAL

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwhonce
Copy link
Member

jwhonce commented Jan 23, 2024

LGTM
/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit ce63c3d into containers:main Jan 23, 2024
13 checks passed
@umohnani8
Copy link
Member Author

/hold cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify usage of workdir, work_dir and working_dir
5 participants