-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workdir
as alias for working_dir
#368
Conversation
Currently `podman-py` uses all three versions of `work_dir`, `working_dir` and `workdir` (not to mention `WorkingDir`). This commit tries to unify the parameter usage by allowing `workdir` for container `create` or `run`. For backwards compatibility `working_dir` still works. Since upstream Podman uses a variety of *workdir* versions the `podman-py` codebase can't be simplified further. Fix: containers#330 Signed-off-by: Paul Spooren <[email protected]> Signed-off-by: Urvashi Mohnani <[email protected]>
Replacing #332 |
What about the tests? |
@rhatdan no tests are needed, we are just adding an alias |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/hold cancel |
Currently
podman-py
uses all three versions ofwork_dir
,working_dir
andworkdir
(not to mentionWorkingDir
).This commit tries to unify the parameter usage by allowing
workdir
for containercreate
orrun
. For backwards compatibilityworking_dir
still works.Since upstream Podman uses a variety of workdir versions the
podman-py
codebase can't be simplified further.Fix: #330