/run/user/$UID as fallback if XDG_RUNTIME_DIR is not set #475
Conversation
There was a problem hiding this comment.
Thanks for your changes. All makes sense to me. I would like to get all green checks in our automation before approving.
please address my comment and also check your commit summary. it contains long links that you can split so the checker won't complain that are longer than 72 characters. for me it's fine to split the urls even if they won't be clickable.
once the tests pass we can give this PR a go! :)
feel free to ask if you have more questions or if you want to design a test for your use case that would be awesome
eighthave
changed the title
XDG mentions `/run/user/$UID` as the value for `XDG_RUNTIME_DIR`: https://www.freedesktop.org/software/systemd/man/latest/pam_systemd.html https://serverfault.com/questions/388840/good-default-for-xdg-runtime-di r/727994#727994 Archlinux, Debian, RedHat, Ubuntu, etc all use `/run/user/$UID` because they follow XDG: https://wiki.archlinux.org/title/XDG_Base_Directory Signed-off-by: Hans-Christoph Steiner <[email protected]>
|
I added two unit tests and addressed all the requested changes. And the tests all pass now. |
|
Thanks @eighthave /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eighthave, inknos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
XDG mentions
/run/user/$UIDas the value forXDG_RUNTIME_DIR:Archlinux, Debian, RedHat, Ubuntu, etc all use
/run/user/$UIDbecause they follow XDG:I found this while using podman-py on a minimal headless Debian server setup, where
/run/user/$UIDwas in use butXDG_RUNTIME_DIRwas not set. The existing fallback in/tmpdid not work.