-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give decent error message if model not found #2
Conversation
curl -fsSL https://raw.githubusercontent.com/containers/ramalama/main/install.sh | sudo bash | ||
|
||
set +o pipefail | ||
./ramalama -h | grep Usage: | ||
set -o pipefail | ||
|
||
ramalama pull granite-code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
@@ -11,14 +11,14 @@ main() { | |||
apt install -y python3-autopep8 | |||
fi | |||
|
|||
./podman-build.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is about this is, it doesn't build ramalama, it only builds container images...
Maybe container-build.sh ?
Not a blocking issue for this PR anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can catch in a follow on PR if needs be
@@ -7,18 +7,22 @@ available() { | |||
main() { | |||
set -ex -o pipefail | |||
|
|||
if ! available autopep8 && available apt; then | |||
apt install -y python3-autopep8 | |||
if ! available autopep8; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already fixed the sudo thing, it's one of the reasons we have conflicts in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting on green build
@ericcurtin can we use the small model for ci rather then granite? |
@rhatdan I'll switch to moondream from Ollama registry, it's smaller, although there may be even smaller than that |
We just need a chmod a+x or whatever to fix CI here I think, assuming python style is autopep8 auto-formatted, etc. |
We can do the moondream change is this PR if needs be too |
"tinyllama" is even smaller |
Rename podman_build.sh to build.sh Signed-off-by: Daniel J Walsh <[email protected]>
Rename podman_build.sh to build.sh