Add vulkan image and show size #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a replacement for #270 |
ericcurtin
commented
Oct 22, 2024
|
|
||
| RUN git clone https://github.com/ggerganov/llama.cpp && \ | ||
| cd llama.cpp && \ | ||
| git reset --hard ${LLAMA_CPP_SHA} && \ |
There was a problem hiding this comment.
@rhatdan do you know if ARGS like LLAMA_CPP_SHA and WHISPER_CPP_SHA get inherited from parent container images?
There was a problem hiding this comment.
I'm assuming they don't, but I don't know
There was a problem hiding this comment.
Only if they are set as Environment variables, which currently they are not. If we want this to be set we could do it via environment in ramalama Containerfile
env LLAMA_CPP_SHA=${LLAMA_CPP_SHA}
There was a problem hiding this comment.
Cool that's better, I'll merge yours
rhatdan
reviewed
Oct 22, 2024
container-images/rocm/Containerfile
Outdated
| @@ -2,6 +2,9 @@ FROM quay.io/ramalama/ramalama:latest | |||
|
|
|||
| RUN /usr/bin/python3 --version | |||
|
|
|||
| ARG LLAMA_CPP_SHA=3f1ae2e32cde00c39b96be6d01c2997c29bae555 | |||
rhatdan
reviewed
Oct 22, 2024
| @@ -0,0 +1,27 @@ | |||
| FROM quay.io/ramalama/ramalama:latest | |||
|
|
|||
| ARG LLAMA_CPP_SHA=3f1ae2e32cde00c39b96be6d01c2997c29bae555 | |||
Add this image, we also want to see the size of this image in the build. Co-authored-by: Steffen Roecker <[email protected]> Signed-off-by: Eric Curtin <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this image, we also want to see the size of this image in the build.
Co-authored-by: Steffen Roecker [email protected]
Signed-off-by: Eric Curtin [email protected]