Enable GCC Toolet 12 to support AVX VNNI

[nzwulfin]

Fixes issue #471 based on a Red Hat KBase article (subscription required), to use AVX VNNI on platforms that support it a later version of binutils is needed.

This adds the GCC 12 Toolset and directly sources the environment vars into the build script.

There are also toolsets available for GCC 13 and 14 available if there's a need for more current versions. They should work the same way.

Summary by Sourcery

Build:

• Add GCC Toolset 12 to the build script for AVX VNNI support.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR enables AVX VNNI support by upgrading the GCC compiler to version 12 through the GCC toolset. The implementation modifies the build script to install and activate GCC toolset 12 specifically for CUDA builds.

Sequence diagram for the build script modification

sequenceDiagram
    participant Developer
    participant BuildScript
    participant System
    Developer->>BuildScript: Modify script to include GCC toolset 12
    BuildScript->>System: Install gcc-toolset-12
    BuildScript->>System: Source /opt/rh/gcc-toolset-12/enable
    System-->>BuildScript: GCC toolset 12 enabled

Loading

Class diagram for the build script changes

classDiagram
    class BuildScript {
        - rpm_list: Array
        + dnf_install(containerfile)
    }
    note for BuildScript "Added gcc-toolset-12 installation and sourcing for CUDA builds"

Loading

File-Level Changes

Change	Details	Files
Added GCC toolset 12 installation and activation for CUDA builds	Added gcc-toolset-12 to the CUDA-specific package installation list Added source command to enable GCC toolset 12 environment variables	container-images/scripts/build_llama_and_whisper.sh

Possibly linked issues

• Local cuda container build fails with "unsupported instruction `vpdpbusd'" #471: The PR adds GCC Toolset 12 to resolve the unsupported vpdpbusd instruction error in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @nzwulfin - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please add a brief comment in the script explaining that GCC 12 toolset is needed for AVX VNNI support

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

You have to sign your commits

git commit -a --amend -s
git push --force

[nzwulfin]

Thanks @rhatdan, should be signed now. I don't need to update this PR right?

[rhatdan]

@bmahabirbu PTAL
LGTM

[bmahabirbu]

Looks good!