Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle leak #2238

Closed
wants to merge 5 commits into from
Closed

Fix handle leak #2238

wants to merge 5 commits into from

Conversation

Bbulatov
Copy link

Possible solve

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Bbulatov
Once this PR has been reviewed and has the lgtm label, please assign mtrmac for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This

  • doesn’t fix the issue at all, AFAICS
  • Introduces a different leak

This is what defer, and maybe the existing if !succeeded pattern, is for.

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 30, 2025

Reference #2237 .

Signed-off-by: Марк Булатов <[email protected]>
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/containers/storage/blob/main/CONTRIBUTING.md#sign-your-prs please, we can’t really even look at PRs with unclear copyright status.

@Bbulatov Bbulatov closed this Feb 10, 2025
@Bbulatov Bbulatov deleted the leak_fix branch February 10, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants