Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHP 8 and Symfony 7 #91

Merged
merged 2 commits into from
May 2, 2024
Merged

Update to PHP 8 and Symfony 7 #91

merged 2 commits into from
May 2, 2024

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Apr 30, 2024

Is it a good idea to commit the composer.lock file? The PHP version is now locked to 8.3 (my local version), even though the minimum requirement is only PHP 8.1.

@leofeyer leofeyer self-assigned this Apr 30, 2024
@leofeyer leofeyer requested a review from Toflar April 30, 2024 15:22
Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick now that we have new features available :)

bin/dump-routes Show resolved Hide resolved
@Toflar
Copy link
Member

Toflar commented Apr 30, 2024

Is it a good idea to commit the composer.lock file? The PHP version is now locked to 8.3 (my local version), even though the minimum requirement is only PHP 8.1.

Of course it's good. It's an app :) We can hardcode the requirement in platform.config if you want that. But imho we can also adjust the require to ^8.3.

@leofeyer leofeyer merged commit da3ce2e into main May 2, 2024
3 checks passed
@leofeyer leofeyer deleted the php8 branch May 2, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants