Merge netmaster and auth_proxy #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseevr
reviewed
Jul 7, 2017
| @@ -273,88 +260,17 @@ spec: | |||
| configMapKeyRef: | |||
| name: contiv-config | |||
| key: config | |||
| securityContext: | |||
There was a problem hiding this comment.
Why are we able to drop the privileged requirement here?
There was a problem hiding this comment.
netmaster does not need to be a privileged container. It has k8s 1.6 RBAC to ask for the privileges it needs.
rchirakk
reviewed
Jul 11, 2017
| - name: contiv-api-proxy | ||
| image: contiv/auth_proxy:__CONTIV_VERSION__ | ||
| args: | ||
| - --tls-key-file=/var/contiv/auth_proxy_key.pem | ||
| - --tls-certificate=/var/contiv/auth_proxy_cert.pem | ||
| - --data-store-address=$(CONTIV_ETCD) | ||
| - --netmaster-address=__NETMASTER_IP__:9999 | ||
| - --netmaster-address=localhost:9999 |
There was a problem hiding this comment.
localhost:9999
is it going to work when listen URL is specified for netmaster?
There was a problem hiding this comment.
That is part of #196 which is in review as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also cleans up most of the unused mounts for netmaster & netplugin.
Removing the
-xflag for netplugin. Lets deal with cleanup/upgrades separately.This is the first part of HA implementation for Contiv on K8s. TBD is etcd HA - I am still trying to understand/decide whether to go with StatefulSets or use the etcd operator for this.
This resolves https://github.com/contiv/ccn/issues/95 and https://github.com/contiv/ccn/issues/319.