Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colors terminfo entry from 256 up to 32767 colors #1697

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

christianparpart
Copy link
Member

With a little bit of help, I've got msgcat --color=test to output true colors in the "hue/saturation" section, which looks partly like this:

image

While this one better exposes the colors supported by Contour, we still have a remaining problem. gettext (the package providing msgcat executable) is heavily hardcoded down to xterm 🤮), so we need to make it pretend we are exterm by symlinking c/contour terminfo file to x/xterm-contour.

We should probably talk to the gettext guys to make their heuristic less xterm-centric.

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Jan 2, 2025
@christianparpart christianparpart force-pushed the improvement/terminfo-colors-int32max branch from 273f35f to c476667 Compare January 2, 2025 20:45
@github-actions github-actions bot added the test Unit tests label Jan 2, 2025
@christianparpart christianparpart force-pushed the improvement/terminfo-colors-int32max branch from c476667 to 71093a0 Compare January 2, 2025 20:57
@christianparpart christianparpart force-pushed the improvement/terminfo-colors-int32max branch from 71093a0 to 4bf903c Compare January 2, 2025 21:05
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@christianparpart christianparpart merged commit b1eeafa into master Jan 2, 2025
31 checks passed
@christianparpart christianparpart deleted the improvement/terminfo-colors-int32max branch January 2, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit tests VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants