Allow naming of the tabs #1705
Open
Allow naming of the tabs #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VT: Backend
src/vtbackend/StatusLineBuilder.cpp
Outdated
| @@ -156,6 +157,7 @@ std::optional<StatusLineDefinitions::Item> makeStatusLineItem( | |||
| styles, | |||
| activeColor, | |||
| activeBackground, | |||
| std::nullopt, | |||
There was a problem hiding this comment.
can we use designated initializers here?
There was a problem hiding this comment.
I will add a comment, that this is separator, because this class has an inheritance and we can not use designated initialization here :(
Yaraslaut
force-pushed
the
feature/tabs_naming
branch
4 times, most recently
from
e0b350e to
9469f71
Compare
Yaraslaut
force-pushed
the
feature/tabs_naming
branch
from
9469f71 to
6e4d8cc
Compare
Yaraslaut
force-pushed
the
feature/tabs_naming
branch
from
6e4d8cc to
ab2db50
Compare
Yaraslaut
force-pushed
the
feature/tabs_naming
branch
from
ab2db50 to
6b91660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1690
Closes #296
PR Adds naming to the tabs, and adds another option to the Tabs status line config, separator