Merge pull request #262 from convergence-rfq/fix-getResponseState

Fix get response state
convergence-rfq · Dec 13, 2023 · c271458 · c271458
2 parents 2d16c89 + 1a3c3af
commit c271458
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 4 deletions.
diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @convergence-rfq/cli
 
+## 4.5.21
+
+### Patch Changes
+
+- Updated dependencies
+  - @convergence-rfq/sdk@4.5.21
+
 ## 4.5.20
 
 ### Patch Changes

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@convergence-rfq/cli",
   "description": "Official Convergence CLI",
-  "version": "4.5.20",
+  "version": "4.5.21",
   "license": "MIT",
   "publishConfig": {
     "access": "public"
@@ -47,7 +47,7 @@
     "cli": "ts-node src/index.ts"
   },
   "dependencies": {
-    "@convergence-rfq/sdk": "4.5.20",
+    "@convergence-rfq/sdk": "4.5.21",
     "@solana/web3.js": "^1.73.0",
     "@types/cookie": "^0.5.1",
     "commander": "^10.0.0"

diff --git a/packages/js/CHANGELOG.md b/packages/js/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @convergence-rfq/sdk
 
+## 4.5.21
+
+### Patch Changes
+
+- Fix getResponseState to avoid conflict between enum DefaultingParty.Talker (0) and null
+
 ## 4.5.20
 
 ### Patch Changes

diff --git a/packages/js/package.json b/packages/js/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@convergence-rfq/sdk",
   "description": "Official Convergence RFQ SDK",
-  "version": "4.5.20",
+  "version": "4.5.21",
   "license": "MIT",
   "publishConfig": {
     "access": "public"

diff --git a/packages/js/src/plugins/rfqModule/operations/getResponseStateAndAction.ts b/packages/js/src/plugins/rfqModule/operations/getResponseStateAndAction.ts
@@ -256,7 +256,7 @@ const getDefautingParty = (
   takerPrepared: boolean
 ): DefaultingParty | null => {
   const { defaultingParty } = response;
-  if (defaultingParty) return defaultingParty;
+  if (defaultingParty !== null) return defaultingParty;
   const defaulted =
     settlementWindowElapsed && (!makerPrepared || !takerPrepared);