Sdk 373 add method to return rfq bid and ask amounts for structure #241
Conversation
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| default: | ||
| break; | ||
| } | ||
| } else if (size.type === 'fixed-quote') { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| */ | ||
| export const retrieveBidAndAskHandler: SyncOperationHandler<RetrieveBidAndAsk> = | ||
| { | ||
| handle: (operation: RetrieveBidAndAsk): RetrieveBidAndAskOutput => { |
There was a problem hiding this comment.
Function handle has 124 lines of code (exceeds 25 allowed). Consider refactoring.
| throw new Error('ask and bid both cannot be null'); | ||
| } | ||
|
|
||
| if (size.type === 'fixed-base') { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| */ | ||
| export const retrieveBidAndAskHandler: SyncOperationHandler<RetrieveBidAndAsk> = | ||
| { | ||
| handle: (operation: RetrieveBidAndAsk): RetrieveBidAndAskOutput => { |
There was a problem hiding this comment.
Function handle has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
SDK-373 Add method to return RFQ bid and ask amounts for structure
See: // Create and return bid and ask objects for response |
| ask.legsMultiplier | ||
| ); | ||
| } | ||
| if (bid?.price && bid.legsMultiplier) { |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
| */ | ||
| export const retrieveBidAndAskHandler: SyncOperationHandler<RetrieveBidAndAsk> = | ||
| { | ||
| handle: (operation: RetrieveBidAndAsk): RetrieveBidAndAskOutput => { |
There was a problem hiding this comment.
Function handle has 105 lines of code (exceeds 25 allowed). Consider refactoring.
| } else if (size.type === 'open') { | ||
| switch (rfq.orderType) { | ||
| case 'buy': | ||
| if (ask?.price && ask.legsMultiplier) { |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
| } | ||
| break; | ||
| case 'sell': | ||
| if (bid?.price && bid.legsMultiplier) { |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
| } | ||
| break; | ||
| case 'two-way': | ||
| if (ask?.price && ask.legsMultiplier) { |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
| */ | ||
| export const retrieveBidAndAskHandler: SyncOperationHandler<RetrieveBidAndAsk> = | ||
| { | ||
| handle: (operation: RetrieveBidAndAsk): RetrieveBidAndAskOutput => { |
There was a problem hiding this comment.
Function handle has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
| } | ||
| } else if (size.type === 'open') { | ||
| switch (rfq.orderType) { | ||
| case 'buy': |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ); | ||
| } | ||
| break; | ||
| case 'sell': |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| } | ||
| } else if (size.type === 'fixed-quote') { | ||
| switch (rfq.orderType) { | ||
| case 'buy': |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ); | ||
| } | ||
| break; | ||
| case 'sell': |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit a2e0444 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Addition : Add retrieveBidAndAsk which return ask , bid after checks along with conversions needed as an input for RespondToRfq operation.
Test: