Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK - fix options rfq underlying asset token mapping during #242

Closed
wants to merge 3 commits into from
Closed

SDK - fix options rfq underlying asset token mapping during #242

wants to merge 3 commits into from

Conversation

Nagaprasadvr
Copy link
Contributor

Fix : fetch underlyingMint and add a method getBaseAssetMint for legInstruments

@linear
Copy link

linear bot commented Sep 11, 2023

UI-1228 Fix Options RFQ Underlying asset token mapping during formatting RFqs

Steps to Reproduce :

  1. Go to RFQ Builder
  2. Choose Different types of sol as base assets and create RFq
  3. Observe all option rfqs point to Wsol currently

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

⚠️ No Changeset found

Latest commit: 50548de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codeclimate[bot]
codeclimate bot reviewed Sep 11, 2023
View reviewed changes
packages/js/src/plugins/psyoptionsEuropeanInstrumentModule/helpers.ts
@@ -264,3 +266,9 @@ export const getOrCreateEuropeanOptionATAs = async (
}
return ATAExistence.NOTEXISTS;
};

export function hasPsyoptionsEuropeanLeg(legs: Leg[]): boolean {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

packages/js/src/plugins/psyoptionsAmericanInstrumentModule/helpers.ts
@@ -185,3 +187,9 @@ export const getOrCreateAmericanOptionATAs = async (
}
return ATAExistence.NOTEXISTS;
};

export function hasPsyoptionsAmericanLeg(legs: Leg[]): boolean {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Sep 11, 2023

Code Climate has analyzed commit 50548de and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

View more on Code Climate.

@Nagaprasadvr Nagaprasadvr marked this pull request as draft September 11, 2023 10:41
@Nagaprasadvr Nagaprasadvr changed the title UI 1228 fix options rfq underlying asset token mapping during SDK - fix options rfq underlying asset token mapping during Sep 14, 2023
@pindaroso pindaroso closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nagaprasadvr @pindaroso