Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev fix duplicate atas #251

Closed
wants to merge 12 commits into from
Closed

Dev fix duplicate atas #251

wants to merge 12 commits into from

Conversation

Nagaprasadvr
Copy link
Contributor

fix duplicate ata Txs

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b1dc1e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codeclimate[bot]
codeclimate bot reviewed Sep 29, 2023
View reviewed changes
packages/js/src/plugins/rfqModule/operations/getResponseStateAndAction.ts
response.takerCollateralLocked > 0 ||
response.makerCollateralLocked > 0
)
return 'UnlockCollateral';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this function.

packages/js/src/plugins/rfqModule/operations/getResponseStateAndAction.ts
response.takerCollateralLocked === 0 &&
response.makerCollateralLocked === 0
)
return 'Cleanup';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this function.

@codeclimate
Copy link

codeclimate bot commented Sep 29, 2023

Code Climate has analyzed commit b1dc1e2 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 2

View more on Code Climate.

@Nagaprasadvr Nagaprasadvr marked this pull request as draft September 29, 2023 12:26
@Nagaprasadvr
Copy link
Contributor Author

closing this and opening a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@EquilateralDelta EquilateralDelta Awaiting requested review from EquilateralDelta

@pindaroso pindaroso Awaiting requested review from pindaroso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nagaprasadvr