Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev technical debt #252

Merged
merged 17 commits into from
Oct 4, 2023
Merged

Dev technical debt #252

merged 17 commits into from
Oct 4, 2023

Conversation

Nagaprasadvr
Copy link
Contributor

  1. Fix Technical Debt
  2. Optimize code
  3. implement American PUT options

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e46771e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nagaprasadvr Nagaprasadvr changed the base branch from main to dev October 4, 2023 07:36
codeclimate[bot]
codeclimate bot reviewed Oct 4, 2023
View reviewed changes
packages/js/src/plugins/rfqModule/operations/getResponseStateAndAction.ts
response.takerCollateralLocked > 0 ||
response.makerCollateralLocked > 0
)
return 'UnlockCollateral';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this function.

packages/js/src/plugins/rfqModule/operations/getResponseStateAndAction.ts
response.takerCollateralLocked === 0 &&
response.makerCollateralLocked === 0
)
return 'Cleanup';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this function.

@codeclimate
Copy link

codeclimate bot commented Oct 4, 2023

Code Climate has analyzed commit e46771e and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 2

View more on Code Climate.

@pindaroso pindaroso merged commit 8ffa4e1 into dev Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@EquilateralDelta EquilateralDelta EquilateralDelta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nagaprasadvr @EquilateralDelta @pindaroso