Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get response state #262

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix get response state #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da355fa
fix getResponseState
Nagaprasadvr Dec 12, 2023
1a3c3af
changelog|
Nagaprasadvr Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @convergence-rfq/cli

## 4.5.21

### Patch Changes

- Updated dependencies
- @convergence-rfq/[email protected]

## 4.5.20

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@convergence-rfq/cli",
"description": "Official Convergence CLI",
"version": "4.5.20",
"version": "4.5.21",
"license": "MIT",
"publishConfig": {
"access": "public"
Expand Down Expand Up @@ -47,7 +47,7 @@
"cli": "ts-node src/index.ts"
},
"dependencies": {
"@convergence-rfq/sdk": "4.5.20",
"@convergence-rfq/sdk": "4.5.21",
"@solana/web3.js": "^1.73.0",
"@types/cookie": "^0.5.1",
"commander": "^10.0.0"
Expand Down
6 changes: 6 additions & 0 deletions packages/js/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# @convergence-rfq/sdk

## 4.5.21

### Patch Changes

- Fix getResponseState to avoid conflict between enum DefaultingParty.Talker (0) and null

## 4.5.20

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@convergence-rfq/sdk",
"description": "Official Convergence RFQ SDK",
"version": "4.5.20",
"version": "4.5.21",
"license": "MIT",
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/js/src/plugins/rfqModule/operations/getResponseStateAndAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ const getDefautingParty = (
takerPrepared: boolean
): DefaultingParty | null => {
const { defaultingParty } = response;
if (defaultingParty) return defaultingParty;
if (defaultingParty !== null) return defaultingParty;
const defaulted =
settlementWindowElapsed && (!makerPrepared || !takerPrepared);

Expand Down
Loading