-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev add cli commad to add all jupiter tokens as base assets #270
Conversation
|
Can we also add a command to update base assets? @Nagaprasadvr |
done |
packages/cli/.gitignore
Outdated
@@ -0,0 +1 @@ | |||
.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove the .env file and use command line arguments instead
packages/cli/package.json
Outdated
@@ -50,7 +50,8 @@ | |||
"@convergence-rfq/sdk": "4.5.29", | |||
"@solana/web3.js": "^1.87.6", | |||
"@types/cookie": "^0.5.1", | |||
"commander": "^10.0.0" | |||
"commander": "^10.0.0", | |||
"dotenv": "^16.4.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
packages/cli/src/actions.ts
Outdated
@@ -259,7 +263,7 @@ export const getRfq = async (opts: Opts) => { | |||
.rfqs() | |||
.findRfqByAddress({ address: new PublicKey(opts.address) }); | |||
logRfq(rfq); | |||
rfq.legs.map(logInstrument); | |||
// rfq.legs.map(logInstrument); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nagaprasadvr Need to add this back int
packages/cli/src/index.ts
Outdated
@@ -1,5 +1,7 @@ | |||
#!/usr/bin/env node | |||
import dotenv from 'dotenv'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
packages/cli/src/index.ts
Outdated
import { makeCli } from './cli'; | ||
|
||
dotenv.config(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
@@ -148,7 +148,6 @@ export const logRfq = (r: Rfq) => { | |||
l('Taker:', r.taker.toString()); | |||
l('Order type:', r.orderType); | |||
l('Size:', r.size.type === 'open' ? 'open' : 'fixed'); | |||
l('Quote asset:', r.quoteMint.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nagaprasadvr Need to add this back int
No description provided.