Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev add cli commad to add all jupiter tokens as base assets #270

Merged
merged 12 commits into from
Feb 16, 2024

Conversation

Nagaprasadvr
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Feb 9, 2024

⚠️ No Changeset found

Latest commit: 7b70524

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pindaroso
Copy link
Contributor

Can we also add a command to update base assets? @Nagaprasadvr

@Nagaprasadvr
Copy link
Contributor Author

Can we also add a command to update base assets? @Nagaprasadvr

done

@@ -0,0 +1 @@
.env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove the .env file and use command line arguments instead

@@ -50,7 +50,8 @@
"@convergence-rfq/sdk": "4.5.29",
"@solana/web3.js": "^1.87.6",
"@types/cookie": "^0.5.1",
"commander": "^10.0.0"
"commander": "^10.0.0",
"dotenv": "^16.4.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -259,7 +263,7 @@ export const getRfq = async (opts: Opts) => {
.rfqs()
.findRfqByAddress({ address: new PublicKey(opts.address) });
logRfq(rfq);
rfq.legs.map(logInstrument);
// rfq.legs.map(logInstrument);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need logging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nagaprasadvr Need to add this back int

@@ -1,5 +1,7 @@
#!/usr/bin/env node
import dotenv from 'dotenv';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

import { makeCli } from './cli';

dotenv.config();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -148,7 +148,6 @@ export const logRfq = (r: Rfq) => {
l('Taker:', r.taker.toString());
l('Order type:', r.orderType);
l('Size:', r.size.type === 'open' ? 'open' : 'fixed');
l('Quote asset:', r.quoteMint.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nagaprasadvr Need to add this back int

@pindaroso pindaroso merged commit 73bff4e into dev Feb 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants