Pull metaplex-solita upstream changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: add sets integration test * typemapper: add set support * deps: upgrade to latest beet supporting sets
* feat: propagate IDL gen exit code and printing warning message if non-zero * chore: printing handler error in red
* fix: IdlAccountsCollection included * lint:fix, test:integration, some fixes * comment changes * chore: move accounts collection guard to where the other guards are * chore: improve naming of account collection items - adding collection name as prefix makes it easier to discover collection items via intellisense, i.e. `sourceMarketItemCoinVault` as well as making clear where each account item originated from * chore: remove unused import * chore: fix fixture name Co-authored-by: ricardocr987 <[email protected]>
* fix prettier command * optional support * fix unit test * remove accidental code addition * use explicit style instead of coercion * chore: rename defaultOptionalsToProgramId to defaultOptionalAccounts to match shank - also put the relevant test into `.only` mode * fix stuff a bit before refactor * refactored optional stuff * added optional integration test * made renderAccountMetaArray a bit more generic * Revert "made renderAccountMetaArray a bit more generic" This reverts commit 884eedf. That last commit made things more complex and harder to understand. The previous version is much cleaner. * chore: first step at sorting things out and renaming for clarity - separated utility functions that are used in different places and don't access the InstruciontRenderer instance - separated account key rendering into sections depending on optional account strategy used * chore: splitting methods for clarity * chore: prep isOptional adaption * test: adding integration test covering both optional account strategies * chore: include info about optional accounts in instruction doc Co-authored-by: Thorsten Lorenz <[email protected]>
…stbin Fix: use solita rustbin config in shank
…-accounts-after-optional-accounts Allow required accounts after optional accounts when rendering instruction keys
* Add support for isOptional instruction account attribute * Fix lint --------- Co-authored-by: febo <[email protected]>
As the new shank version will assume
Add binaryArgs field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull updated master