Skip to content

Commit

Permalink
Release 10.1.5
Browse files Browse the repository at this point in the history
Found another bug while trying to make the release.

Running `npm run nodeps` last breaks dynamic importing of the DayJS
translations. I'm not sure why, I think maybe because of broken `.map`
files.

The fix for now is to move the js-po files out of the way, and then copy
them back in after running `npm run build`.

Hopefully all of this won't be necessary with gettext 0.22 which should
support template literals
  • Loading branch information
jcbrand committed Jun 29, 2023
1 parent 5e02b9b commit c30569d
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,16 @@ src/headless/dist/converse-headless.min.js: src webpack/webpack.common.js node_m

dist:: node_modules src/* | dist/website.css dist/website.min.css
npm run headless
npm run build
# This step is necessary to properly generate JSON files from the .po
# files. The nodeps config uses preset-env with IE11 to turn all template
# literals into old JS strings, which is required because gettext 0.21
# doesn't support template literals.
# Ideally this should just be `npm run nodeps`.
# The additional steps are necessary to properly generate JSON files from
# the .po files. The nodeps config uses preset-env with IE11 to turn all
# template literals into old JS strings, which is required because
# gettext 0.21 doesn't support template literals.
npm run nodeps
mkdir tmp && mv dist/locales tmp
npm run build
cp tmp/locales/*-po.js dist/locales/
rm -rf tmp

.PHONY: install
install:: dist
Expand Down

0 comments on commit c30569d

Please sign in to comment.