-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Team Dashboard): Temporarily hide team stats block #362
feat(Team Dashboard): Temporarily hide team stats block #362
Conversation
size-limit report 📦
|
0fdfea6
to
e41e987
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message
- feat(Team Dashboard): Temporarily hide team stats block
+ feat(cxl-ui): cxl-dashboard-team-stats add hide progress, stats properties
I flipped the logic to make it a bit clearer. Instead of show, it's now hide.
IMO using
${this.showProgress ? html`` : nothing
is easier to read than
${!this.hideProgress ? html`` : nothing
but let it stay and not waste time on opinions ;)
e41e987
to
d2fb82d
Compare
I agree with you. From a developer's perspective, it might be a bit harder to read, but in terms of overall logic, it seems more logical to me that the element is visible in normal situations, and then we want to hide it in certain cases. |
@HenerHoop conflicts appeared after merging #361. Please resolve them |
d2fb82d
to
9b23945
Compare
https://app.clickup.com/t/86ayqffyf