Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed calendar definition fix ltr #288

Merged

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented May 19, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Minor tweaks for #287.

@landonreed landonreed changed the base branch from dev to mixed-calendar-definition-fix May 19, 2020 14:04
@landonreed landonreed requested a review from evansiroky May 19, 2020 14:06
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #288 into mixed-calendar-definition-fix will decrease coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##             mixed-calendar-definition-fix     #288      +/-   ##
===================================================================
- Coverage                            65.38%   65.35%   -0.03%     
  Complexity                             880      880              
===================================================================
  Files                                  135      135              
  Lines                                 6749     6749              
  Branches                               793      793              
===================================================================
- Hits                                  4413     4411       -2     
- Misses                                2036     2038       +2     
  Partials                               300      300              
Impacted Files Coverage Δ Complexity Δ
.../com/conveyal/gtfs/loader/JdbcGtfsSnapshotter.java 82.29% <88.88%> (ø) 26.00 <0.00> (ø)
src/main/java/com/conveyal/gtfs/PatternFinder.java 85.22% <0.00%> (-2.28%) 20.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5faeff...e659d14. Read the comment docs.

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evansiroky evansiroky merged commit a161dd7 into mixed-calendar-definition-fix May 19, 2020
@evansiroky evansiroky deleted the mixed-calendar-definition-fix-ltr branch May 19, 2020 16:17
@landonreed landonreed mentioned this pull request May 19, 2020
7 tasks
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 6.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants