Reintroduce CocoaPod support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamnichols
force-pushed
the
ln/cocoapods
branch
from
af75f89 to
af68072
Compare
liamnichols
force-pushed
the
ln/cocoapods
branch
from
af68072 to
a86f11e
Compare
liamnichols
changed the title
Merged
|
Feel free to merge this after reviewing 🙇 |
|
Thanks for responding! Merging 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally created this fork purely because the main twitter/ios-twitter-image-pipeline is no longer maintained and we needed SPM support, but now we also want to use this fork for other enhancements (#3).
Since we are yet to complete the transition to SPM, we need this fork to also offer partial CocoaPods support. Unlike the main repo, we are only supporting the main target and not the additional codecs to keep things simple.
When testing this change, I realised that I used the incorrect type of imports so I have also corrected this in afb19b5