Fix domain persistence in docker_compose_domains #4327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to coollabsio#4326 Update domain persistence in `docker_compose_domains` field after redeployment. * **app/Livewire/Project/Application/General.php** - Add validation for `docker_compose_domains` in the `rules` and `validationAttributes` arrays. * **app/Models/ApplicationPreview.php** - Add `validateDockerComposeDomainsFormat` method to validate the format of `docker_compose_domains`. * **app/Http/Controllers/Webhook/Bitbucket.php** - Add `validateDockerComposeDomainsFormat` method to validate the format of `docker_compose_domains`. * **app/Http/Controllers/Webhook/Gitea.php** - Add `validateDockerComposeDomainsFormat` method to validate the format of `docker_compose_domains`. * **app/Http/Controllers/Webhook/Github.php** - Add `docker_compose_domains` to the data array when creating a new `ApplicationDeployment`. /claim coollabsio#4326
|
Is this AI generated slop? |
|
Not needed by the author anymore, so I will close it. |
Even a cursory glance would tell you that creating private methods that are never called makes no sense, notwithstanding that same code was copy/pasted three times and this guy only showed up to collect the bounty (has no prior contributions to this project). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4326
Update domain persistence in
docker_compose_domainsfield after redeployment.docker_compose_domainsin therulesandvalidationAttributesarrays.validateDockerComposeDomainsFormatmethod to validate the format ofdocker_compose_domains.validateDockerComposeDomainsFormatmethod to validate the format ofdocker_compose_domains.validateDockerComposeDomainsFormatmethod to validate the format ofdocker_compose_domains.docker_compose_domainsto the data array when creating a newApplicationDeployment./claim #4326