-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] company_today #303
Conversation
Signed-off-by: Carmen Bianca Bakker <[email protected]>
…ing it Signed-off-by: Carmen Bianca Bakker <[email protected]>
make company_today cron run once a day at 00:00:00 utc instead of every minute, to avoid recomputing fields that depend on it over and over uselessly. odoo handles all time-related data in utc, so running it more than once after midnight (utc) does not change anything.
set company_today cron as noupdate to allow users to customize it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just a small suggestion (not related to the porting).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as hugues
3a6a4ad
to
e07545e
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## 16.0 #303 +/- ##
==========================================
+ Coverage 97.73% 97.97% +0.23%
==========================================
Files 12 17 +5
Lines 221 247 +26
Branches 30 31 +1
==========================================
+ Hits 216 242 +26
Misses 1 1
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at fa1dca5. Thanks a lot for contributing to coopiteasy. ❤️ |
https://gestion.coopiteasy.be/web#id=10959&action=475&active_id=492&model=project.task&view_type=form&menu_id=