Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] company_today #303

Merged
merged 15 commits into from
Sep 11, 2023
Merged

[16.0] [MIG] company_today #303

merged 15 commits into from
Sep 11, 2023

Conversation

carmenbianca and others added 14 commits July 26, 2023 10:04
Signed-off-by: Carmen Bianca Bakker <[email protected]>
make company_today cron run once a day at 00:00:00 utc instead of every
minute, to avoid recomputing fields that depend on it over and over
uselessly. odoo handles all time-related data in utc, so running it more
than once after midnight (utc) does not change anything.
set company_today cron as noupdate to allow users to customize it.
@victor-champonnois victor-champonnois changed the title 16.0 mig company today [16.0] [MIG] company_today Jul 26, 2023
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just a small suggestion (not related to the porting).

company_today/__manifest__.py Outdated Show resolved Hide resolved
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as hugues

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Merging #303 (e07545e) into 16.0 (e110213) will increase coverage by 0.23%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             16.0     #303      +/-   ##
==========================================
+ Coverage   97.73%   97.97%   +0.23%     
==========================================
  Files          12       17       +5     
  Lines         221      247      +26     
  Branches       30       31       +1     
==========================================
+ Hits          216      242      +26     
  Misses          1        1              
  Partials        4        4              
Files Changed Coverage Δ
company_today/__init__.py 100.00% <100.00%> (ø)
company_today/models/__init__.py 100.00% <100.00%> (ø)
company_today/models/res_company.py 100.00% <100.00%> (ø)
company_today/tests/__init__.py 100.00% <100.00%> (ø)
company_today/tests/test_today.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-grap-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@victor-champonnois
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-303-by-victor-champonnois-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit ac1e0a3 into 16.0 Sep 11, 2023
2 checks passed
@github-grap-bot github-grap-bot deleted the 16.0-mig-company_today branch September 11, 2023 15:02
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at fa1dca5. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants