Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Converged to infinite with negative condition #3

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

rafaelsimonmaia
Copy link
Contributor

No description provided.

@rafaelsimonmaia rafaelsimonmaia requested a review from idyll October 1, 2024 01:06
lib/ex_xirr.ex Show resolved Hide resolved
@rafaelsimonmaia rafaelsimonmaia changed the title Add Converted to negative condition Add Converged to infinite with negative condition Oct 1, 2024
lib/ex_xirr.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@idyll idyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nathany-copia nathany-copia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional tests?

@rafaelsimonmaia rafaelsimonmaia merged commit 012fb44 into main Oct 1, 2024
1 check passed
@rafaelsimonmaia rafaelsimonmaia deleted the rsm/SC-29844 branch October 1, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants