Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update apiClient() guide #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BThero
Copy link

@BThero BThero commented Sep 19, 2024

The description seems more accurate to me now, but to be honest now I think the code snippet itself might need to be improved to live up to the expectations.

We can't really call it "type-safe" if all we are doing is just asserting the type.

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hq-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 3:54pm

@BThero
Copy link
Author

BThero commented Sep 19, 2024

By the way, adding a new updatedAt field (instead of createdAt) is likely better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant