Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CertiCoq 0.9 ExtLib upper bound #2894

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

liyishuai
Copy link
Member

No description provided.

@@ -27,11 +27,12 @@ install: [
]
depends: [
"ocaml"
"conf-clang"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"conf-clang"
("conf-clang" | "conf-gcc")

It seems unlikely that CertiCoq is tied to Clang specifically, rather than just "any" C compiler. The suggestion is the current best approximation in opam of how to depend on any C compiler.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clang only: CertiCoq/certicoq#62

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc is painfully slow on large examples, but can be used sometimes. Also the compcert compiler can be used. For now clang is the safest bet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked, you were compiling with -O0. In the case of GCC, this is a bad idea because the non-optimized generated code ends up being so large that it bring the compiler backend to its knees. GCC is often faster when using -O1 (not counting the huge benefit for the compiled program).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status of this thread? I can see two directions:

  1. Test gcc -O1. If it works fine, then allow either Clang or GCC as dependency; or
  2. Stick to Clang, and install it in the CI environment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @mattam82 can make the call? You can add Clang into the CI environment by modifying .gitlab-ci.yml.

@liyishuai liyishuai marked this pull request as ready for review January 27, 2024 18:24
@palmskog palmskog merged commit 5f0898e into coq:master Feb 23, 2024
3 checks passed
@liyishuai liyishuai deleted the certicoq-deps branch February 26, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants