Return empty completions rather than error #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot ! Does this close #989 ? |
|
Possibly? Not really sure what the root cause for crashes in #989 was as I’ve never encountered the language server crashing from the completions just giving lots of error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should address the spamming of
Request textDocument/completion failederrors that can be encountered on each character if a completion is not found when"vscoq.completion.enable": true.This does not address anything about the underlying completion algorithm, rather just ensures that we can (almost) always return an empty list of possible completions.
I believe this is a more idiomatic way to implement completions (return either empty list or null) when no completions are available rather than a failure.