Change activation to only occur when Coq files are opened #1028
+2
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think displaying the sidebar only when a .v file is focused sounds fine ! |
Durbatuluk1701
force-pushed
the
activation_changes
branch
from
1bde7c1 to
d39a55c
Compare
|
@rtetley any ideas on why the CI is failing now? It seems odd that it fails for macos 8.18 and 8.20, but succeeds for 8.19 and master? |
|
Probably sporadic fails ! I'll re-run ! |
|
Ugh, I don't know what's happening 😅 I'll investigate tomorrow morning ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1027.
In particular, you will not need the language server involved unless the extension is "activated", and now it should only activate if you have a focused
.vor_CoqProjectfile.How this should work (and in some ways a continuation of discussion in #897):
It may also be worth addressing in this PR suggestions made by @RalfJung (in #897 discussion) about not displaying the sidebar unless you have a currently focused
.vfile. Upon testing, it appears that the sidebar search will not work if you don't have a currently focused.vfile, so displaying it when it won't work would be at best confusing.If we choose to implement this, then additional commits will be needed for that functionality