Sticky cursor for step forward and step backward #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the sticky cursor option in the package.json file - Tried using the updateHighlights notification to update the cursor to no avail - TODO: Will need to create a custom notification type
In the language server: - Added a MoveCursor notification type - Added a function to get the last executed range in the DocumentManager - Added all functions and processes to launch the notification on a stepForward or stepBackward
In the vscode extension: - Added the mechanism to update the cursor on receiving a moveCursor notification.
rtetley
force-pushed
the
enhance/sticky-cursor
branch
from
af2a9b3
to
3229486
Compare
maximedenes
reviewed
Aug 2, 2023
- Renamed the last_executed_range function to observe_id_range - Created a new pre_execution priority - Review priorities so that 1) we mve the cursor, 2) we execute, 3) we display the proof context
maximedenes
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #505.