Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Modals #495

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

ticruz38
Copy link
Collaborator

@ticruz38 ticruz38 commented Nov 28, 2024

Modal Drawer is now the default except for HUD, profiles and feed Edit

The side drawer has a max-width-md applied, opens from the left, the sidebar is still visible and accessible
Screenshot 2024-11-28 at 17 45 11

When another drawer opens it fully covers the first one
Screenshot 2024-11-28 at 17 45 21

When opening a profile page, we still have the former modal, but the side menu is still visible, I thought it was ok, but I can put it in the background if needed
Screenshot 2024-11-28 at 17 46 03

On mobile the modal still open from the bottom, I can open it from the side if needed, it is now dismissible with a swap.

Screen.Recording.2024-11-28.at.17.49.58.mov

@staab staab changed the base branch from master to dev December 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant