Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make solana_account_decoder dep public in anchor client #3455

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

cryptopapi997
Copy link
Contributor

Currently, anchor-client already exports solana_client and solana_sdk to make it easier for the user to not have to manually keep the version between these and anchor client in sync. Unfortunately it does not export solana_account_decoder, even though this one is used internally and is needed to instantiate certain (commonly-used) structs in solana_sdk such as RpcAccountInfoConfig. This means the user has to manually configure its version which is annoying. This can be fixed easily by exporting it too, so this PR adds that.

Copy link

vercel bot commented Dec 27, 2024

@cryptopapi997 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, can do, but let me ask a quick question before we get this in: does it not work if you let cargo decide the proper version by adding it as solana-account-decoder = "*"?

@cryptopapi997
Copy link
Contributor Author

For my current setup setting it to solana-account-decoder = "*" just makes it complain about more dependency conflicts (This obv isn't solely the fault of anchor since my repo is quite large). I currently have a workaround in place using some cargo patch stuff so this addition technically isn't 100% mandatory. I felt like it was a good change nonetheless though, as this is in line with how anchor currently handles the other solana deps & in my specific case (and I suspect other people using anchor client and wanting to use stuff from solana-account-decoder) it would make things a bit easier.

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@acheroncrypto acheroncrypto merged commit 2828514 into coral-xyz:master Dec 28, 2024
52 of 53 checks passed
@cryptopapi997 cryptopapi997 deleted the patch-1 branch December 28, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants