Skip to content

Merge pull request #4347 from coralproject/fix/CORL-2911-comment-coun… #861

Merge pull request #4347 from coralproject/fix/CORL-2911-comment-coun…

Merge pull request #4347 from coralproject/fix/CORL-2911-comment-coun… #861

Triggered via push September 26, 2023 19:19
Status Success
Total duration 1h 4m 2s
Artifacts
Build and Test
1h 3m
Build and Test
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Build and Test: client/src/core/client/account/routes/email/Confirm/ConfirmForm.tsx#L33
React Hook useCallback has missing dependencies: 'confirm' and 'onSuccess'. Either include them or remove the dependency array. If 'onSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback
Build and Test: client/src/core/client/account/routes/notifications/Unsubscribe/UnsubscribeForm.tsx#L36
React Hook useCallback has missing dependencies: 'onSuccess' and 'unsubscribe'. Either include them or remove the dependency array. If 'onSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback
Build and Test: client/src/core/client/account/routes/password/Reset/ResetPasswordForm.tsx#L50
React Hook useCallback has missing dependencies: 'onSuccess' and 'resetPassword'. Either include them or remove the dependency array. If 'onSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback
Build and Test: client/src/core/client/admin/components/ConversationModal/ConversationModalCommentContainer.tsx#L87
React Hook useCallback has an unnecessary dependency: 'match'. Either exclude it or remove the dependency array
Build and Test: client/src/core/client/admin/components/ConversationModal/ConversationModalHeaderContainer.tsx#L29
React Hook useCallback has missing dependencies: 'comment.story.id' and 'router'. Either include them or remove the dependency array
Build and Test: client/src/core/client/admin/components/StoryInfoDrawer/RecacheStoryAction.tsx#L38
React Hook useCallback has a missing dependency: 'reset'. Either include it or remove the dependency array
Build and Test: client/src/core/client/admin/components/StoryInfoDrawer/RecacheStoryAction.tsx#L50
React Hook useCallback has missing dependencies: 'cached' and 'checkIfCached'. Either include them or remove the dependency array
Build and Test: client/src/core/client/admin/components/UserHistoryDrawer/ModeratorNote.tsx#L28
React Hook useCallback has a missing dependency: 'onDelete'. Either include it or remove the dependency array. If 'onDelete' changes too often, find the parent component that defines it and wrap that definition in useCallback
Build and Test: client/src/core/client/admin/components/UserHistoryDrawer/UserDrawerAccountHistory.tsx#L43
The 'system' JSX element makes the dependencies of useMemo Hook (at line 230) change on every render. Move it inside the useMemo callback. Alternatively, wrap the initialization of 'system' in its own useMemo() Hook
Build and Test: client/src/core/client/admin/components/UserHistoryDrawer/UserDrawerNotesContainer.tsx#L44
React Hook useCallback has a missing dependency: 'deleteNote'. Either include it or remove the dependency array