[CORL-2905]: add optional count param to active stories script #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
marcushaddon
approved these changes
Sep 8, 2023
nick-funk
approved these changes
Sep 12, 2023
| @@ -14,11 +14,13 @@ export type Options = Pick<AppOptions, "mongo">; | |||
| const ActiveStoriesQuerySchema = Joi.object().keys({ | |||
| callback: Joi.string().allow("").optional(), | |||
| siteID: Joi.string().required(), | |||
| count: Joi.number().optional().max(999), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes add an optional
countparam to the active stories jsonp script. If thecountparam is passed in, then that is the number of stories that will be returned. If nocountparam is passed, the count defaults to 5.These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can either visit in your browser or run curl against these urls to see that you get the expected response:
http://localhost:8080/api/story/active.js?siteID=SITE_ID(should get the default of 5 stories)http://localhost:8080/api/story/active.js?siteID=SITE_ID&count=10(should get 10 stories)http://localhost:8080/api/story/active.js?siteID=SITE_ID&count=2(should get 2 stories)Note that if your site has fewer than the requested number of stories, all stories will be returned.
Where any tests migrated to React Testing Library?
How do we deploy this PR?