Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static asset deployments for mono-repo #4363

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

Properly upload static assets from new client mono-repo distributables.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

No new indices.

How do I test this PR?

Queue a release build and ensure that static assets are built and uploaded to our artifact registry.

Where any tests migrated to React Testing Library?

No

How do we deploy this PR?

  • Merge into develop
  • Release to main

updated gke yaml to perform this deploy
@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 0d6371f
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/651ee47bbc79990008655e82

@nick-funk nick-funk marked this pull request as ready for review October 5, 2023 16:39
@tessalt tessalt merged commit d2c8495 into develop Oct 5, 2023
5 checks passed
@tessalt tessalt deleted the fix/static-assets-deploy branch October 5, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants