resolves comment

corbado · Sep 11, 2024 · f1e39dc · f1e39dc
1 parent e79e579
commit f1e39dc
Showing 1 changed file with 25 additions and 7 deletions.
diff --git a/src/services/identifierService.ts b/src/services/identifierService.ts
@@ -17,9 +17,21 @@ export interface IdentifierInterface {
   create(userId: string, req: IdentifierCreateReq): Promise<IdentifierRsp>;
   delete(userId: string, identifierId: string): Promise<GenericRsp>;
   list(sort?: string, filter?: string[], page?: number, pageSize?: number): Promise<IdentifierList>;
-  listByValueAndType(value: string, type: IdentifierType): Promise<IdentifierList>;
-  listByUserId(userId: string, page?: number, pageSize?: number): Promise<IdentifierList>;
-  listByUserIdAndType(userId: string, type: IdentifierType, page?: number, pageSize?: number): Promise<IdentifierList>;
+  listByValueAndType(
+    value: string,
+    type: IdentifierType,
+    sort?: string,
+    page?: number,
+    pageSize?: number,
+  ): Promise<IdentifierList>;
+  listByUserId(userId: string, sort?: string, page?: number, pageSize?: number): Promise<IdentifierList>;
+  listByUserIdAndType(
+    userId: string,
+    type: IdentifierType,
+    sort?: string,
+    page?: number,
+    pageSize?: number,
+  ): Promise<IdentifierList>;
   updateIdentifier(
     userId: string,
     identifierId: string,
@@ -114,26 +126,32 @@ class Identifier implements IdentifierInterface {
     return this.list(sort, [`identifierValue:eq:${value}`, `identifierType:eq:${type}`], page, pageSize);
   }
 
-  async listByUserId(userId: string, page?: number, pageSize?: number): Promise<IdentifierList> {
+  async listByUserId(userId: string, sort?: string, page?: number, pageSize?: number): Promise<IdentifierList> {
     let id = userId;
 
     // filter queries are using userID without prefix
     if (userId.startsWith(USER_ID_PREFIX)) {
       id = userId.substring(USER_ID_PREFIX.length);
     }
 
-    return this.list(undefined, [`userID:eq:${id}`], page, pageSize);
+    return this.list(sort, [`userID:eq:${id}`], page, pageSize);
   }
 
-  listByUserIdAndType(userId: string, type: IdentifierType, page?: number, pageSize?: number): Promise<IdentifierList> {
+  listByUserIdAndType(
+    userId: string,
+    type: IdentifierType,
+    sort?: string,
+    page?: number,
+    pageSize?: number,
+  ): Promise<IdentifierList> {
     let id = userId;
 
     // filter queries are using userID without prefix
     if (userId.startsWith(USER_ID_PREFIX)) {
       id = userId.substring(USER_ID_PREFIX.length);
     }
 
-    return this.list(undefined, [`userID:eq:${id}`, `identifierType:eq:${type}`], page, pageSize);
+    return this.list(sort, [`userID:eq:${id}`, `identifierType:eq:${type}`], page, pageSize);
   }
 
   async updateIdentifier(