Feature : integrate new package version to examples #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 36.20% 36.20%
=======================================
Files 21 21
Lines 1555 1555
Branches 288 288
=======================================
Hits 563 563
Misses 936 936
Partials 56 56 ☔ View full report in Codecov by Sentry. |
corbadoman
reviewed
Sep 13, 2024
README.md
Outdated
|
|
||
| const config = new Corbado.Config(projectID, apiSecret); | ||
| const config = new Config(projectID, apiSecret, frontendAPI, backendAPI); |
There was a problem hiding this comment.
its not Corbado.Config anymore, is that correkt? Corbado.SDK() "stayed" :)
corbadoman
reviewed
Sep 13, 2024
examples/identifier/index.js
Outdated
|
|
||
| const router = express.Router(); | ||
| const config = new Config( | ||
| 'pro-1', |
There was a problem hiding this comment.
pro-1 is "scary" because its our own :)
corbadoman
reviewed
Sep 13, 2024
examples/identifier/index.js
Outdated
| const router = express.Router(); | ||
| const config = new Config( | ||
| 'pro-1', | ||
| 'corbado1_hALCgZhe3oSwec8Hr2ZuF9w4DZAo9w', |
There was a problem hiding this comment.
dont commit api secret
work with env file for examples maybe?
corbadoman
reviewed
Sep 13, 2024
examples/session/index.js
Outdated
| config.setBackendAPI('https://api.corbado-dev.com') | ||
| const config = new Config( | ||
| 'pro-1', | ||
| 'corbado1_hALCgZhe3oSwec8Hr2ZuF9w4DZAo9w', |
corbadoman
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.