Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-15443: release GA RC-12 prep #98

Open
wants to merge 4 commits into
base: release/corda-5-0
Choose a base branch
from
Open

CORE-15443: release GA RC-12 prep #98

wants to merge 4 commits into from

Conversation

christian-napoles-r3
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot previously requested changes Jul 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|ES)-\d+)(.*)

tlawson3
tlawson3 requested changes Jul 18, 2023
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
@christian-napoles-r3 christian-napoles-r3 marked this pull request as ready for review July 18, 2023 13:43
@christian-napoles-r3 christian-napoles-r3 requested a review from a team as a code owner July 18, 2023 13:43
@christian-napoles-r3 christian-napoles-r3 changed the title Cnapoles/core 15443/release ga rr12 prep cnapoles/CORE-15443/releaseGaRc12prep Jul 18, 2023
github-actions[bot]
github-actions bot previously requested changes Jul 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|ES)-\d+)(.*)

@christian-napoles-r3 christian-napoles-r3 changed the title cnapoles/CORE-15443/releaseGaRc12prep CORE-15443: release GA RC-12 prep Jul 18, 2023
@github-actions github-actions bot dismissed stale reviews from themself July 18, 2023 13:46

All good!

yarivus
yarivus approved these changes Jul 19, 2023
View reviewed changes
Copy link

@yarivus yarivus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarivus yarivus yarivus approved these changes

@tlawson3 tlawson3 tlawson3 approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christian-napoles-r3 @tlawson3 @yarivus